Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: provide support for groupby #466

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

aaqilniz
Copy link
Contributor

@aaqilniz aaqilniz commented Dec 28, 2023

This PR enables the loopback-connector to apply group by filter & add min(), max(), count(), avg() & sum() in the result.

Related PRs:

Checklist

  • DCO (Developer Certificate of Origin) signed in all commits
  • npm test passes on your machine
  • New tests added or existing tests modified to cover all changes
  • Code conforms with the style guide
  • Commit messages are following our guidelines

@coveralls
Copy link

coveralls commented Dec 28, 2023

Pull Request Test Coverage Report for Build 7842838503

  • -5 of 27 (81.48%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.5%) to 59.862%

Changes Missing Coverage Covered Lines Changed/Added Lines %
lib/sql.js 22 27 81.48%
Totals Coverage Status
Change from base Build 7836864604: 0.5%
Covered Lines: 734
Relevant Lines: 1159

💛 - Coveralls

@aaqilniz aaqilniz force-pushed the feat/support-groupby branch from 37f6f1c to 807e70b Compare January 14, 2024 09:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants